The following document contains the results of Checkstyle
. 
| Files | Infos  |
Warnings  |
Errors  |
|---|---|---|---|
| 75 | 0 | 261 | 0 |
| Rules | Violations | Severity |
|---|---|---|
| IllegalImport | 1 | Warning |
| RedundantImport | 0 | Warning |
| UnusedImports | 0 | Warning |
| ExecutableStatementCount | 4 | Warning |
FileLength
|
2 | Warning |
MethodLength
|
8 | Warning |
AnonInnerLength
|
6 | Warning |
ParameterNumber
|
0 | Warning |
| FinalClass | 6 | Warning |
| HideUtilityClassConstructor | 2 | Warning |
| InterfaceIsType | 0 | Warning |
VisibilityModifier
|
0 | Warning |
| MutableException | 0 | Warning |
ThrowsCount
|
0 | Warning |
| AvoidInlineConditionals | 0 | Ignore |
| CovariantEquals | 0 | Warning |
| DeclarationOrder | 0 | Ignore |
| DefaultComesLast | 0 | Warning |
| DoubleCheckedLocking | 0 | Warning |
| EmptyStatement | 0 | Warning |
| EqualsHashCode | 0 | Warning |
| ExplicitInitialization | 0 | Warning |
| FallThrough | 0 | Warning |
FinalLocalVariable
|
18 | Warning |
HiddenField
|
14 | Warning |
| IllegalCatch | 16 | Warning |
IllegalInstantiation
|
0 | Warning |
IllegalToken
|
2 | Warning |
IllegalTokenText
|
0 | Warning |
| IllegalType | 0 | Warning |
| InnerAssignment | 0 | Warning |
MagicNumber
|
52 | Warning |
| MissingSwitchDefault | 2 | Warning |
| MultipleVariableDeclarations | 0 | Warning |
NestedIfDepth
|
0 | Warning |
| NestedTryDepth | 0 | Warning |
| PackageDeclaration | 0 | Warning |
| ParameterAssignment | 0 | Warning |
| RedundantThrows | 0 | Warning |
ReturnCount
|
1 | Warning |
| SimplifyBooleanExpression | 0 | Warning |
| SimplifyBooleanReturn | 0 | Warning |
| StringLiteralEquality | 0 | Warning |
| SuperClone | 0 | Warning |
| SuperFinalize | 0 | Warning |
| UnnecessaryParentheses | 1 | Warning |
| ArrayTypeStyle | 0 | Warning |
| FinalParameters | 17 | Warning |
| TodoComment | 0 | Warning |
UncommentedMain
|
4 | Warning |
| UpperEll | 0 | Warning |
BooleanExpressionComplexity
|
0 | Warning |
ClassDataAbstractionCoupling
|
5 | Warning |
| ClassFanOutComplexity | 5 | Warning |
| CyclomaticComplexity | 5 | Warning |
| NPathComplexity | 1 | Warning |
| EmptyBlock | 0 | Warning |
| ModifierOrder | 1 | Warning |
| RedundantModifier | 2 | Warning |
| AvoidStarImport | 0 | Warning |
| ImportOrder | 0 | Ignore |
| UnusedImports | 0 | Ignore |
| JavaNCSS | 2 | Warning |
| TodoComment | 0 | Warning |
AbstractClassName
|
0 | Warning |
| ConstantName | 12 | Warning |
| LocalFinalVariableName | 1 | Warning |
| LocalVariableName | 0 | Warning |
| MemberName | 0 | Warning |
| MethodName | 0 | Warning |
| PackageName | 0 | Warning |
| ParameterName | 0 | Warning |
| StaticVariableName | 0 | Warning |
| TypeName | 0 | Warning |
| AvoidNestedBlocks | 0 | Warning |
| NeedBraces | 0 | Warning |
JavadocMethod
|
10 | Warning |
JavadocStyle
|
58 | Warning |
JavadocType
|
3 | Warning |
| StrictDuplicateCode | 0 | Ignore |
| Violation | Message | Line |
|---|---|---|
|
Utility classes should not have a public or default constructor. | 22 |
|
Name '_classpath' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 25 |
|
Uncommented main method found. | 48 |
|
Using '+=' is not allowed. | 78 |
|
Using '+=' is not allowed. | 94 |
|
Catching 'Exception' is not allowed. | 168 |
|
Parameter dir should be final. | 189 |
|
Variable 'dir' should be declared final. | 189 |
|
Parameter name should be final. | 189 |
|
Variable 'name' should be declared final. | 189 |
| Violation | Message | Line |
|---|---|---|
|
Catching 'Exception' is not allowed. | 112 |
| Violation | Message | Line |
|---|---|---|
|
First sentence should end with a period. | 85 |
| Violation | Message | Line |
|---|---|---|
|
Cyclomatic Complexity is 15 (max allowed is 10). | 60 |
|
'date' hides a field. | 280 |
|
'sunrise' hides a field. | 295 |
|
'sunset' hides a field. | 295 |
|
'date' hides a field. | 300 |
|
'24D' is a magic number. | 310 |
|
'24' is a magic number. | 313 |
| Violation | Message | Line |
|---|---|---|
|
File length is 546 lines (max allowed is 500). | 1 |
|
Class Data Abstraction Coupling is 11 (max allowed is 10) classes [ArrayList, DaylightBand, DecimalFormat, File, FileWriter, LocalDate, Options, PrintWriter, RawRiseSet, RiseSet, RiseSetYearData]. | 57 |
|
Class Fan-Out Complexity is 24 (max allowed is 20). | 57 |
|
Name 'sunAlgorithm' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 63 |
|
Method length is 67 lines (max allowed is 50). | 77 |
|
Uncommented main method found. | 166 |
|
Cyclomatic Complexity is 19 (max allowed is 10). | 227 |
|
Method length is 72 lines (max allowed is 50). | 227 |
|
Return count is 4 (max allowed is 3). | 330 |
|
'9' is a magic number. | 341 |
|
'15' is a magic number. | 351 |
|
Unnecessary parentheses around assignment right-hand side. | 402 |
|
Cyclomatic Complexity is 12 (max allowed is 10). | 453 |
|
Executable statement count is 35 (max allowed is 30). | 453 |
|
Method length is 76 lines (max allowed is 50). | 453 |
|
NPath Complexity is 336 (max allowed is 200). | 453 |
|
'3' is a magic number. | 465 |
| Violation | Message | Line |
|---|---|---|
|
'riseSets' hides a field. | 128 |
|
'twilights' hides a field. | 129 |
|
'twilight' hides a field. | 133 |
|
'bands' hides a field. | 169 |
|
Parameter adjustedForDaylightSavings should be final. | 207 |
|
Variable 'adjustedForDaylightSavings' should be declared final. | 207 |
| Violation | Message | Line |
|---|---|---|
|
'-5D' is a magic number. | 33 |
|
'6D' is a magic number. | 33 |
| Violation | Message | Line |
|---|---|---|
|
Name 'chartDimension' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 40 |
|
Name 'monthsFormat' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 43 |
|
Name 'daylightColor' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 46 |
|
Name 'twilightColor' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 48 |
|
Name 'nightColor' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 50 |
|
Name 'chartFont' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 53 |
| Violation | Message | Line |
|---|---|---|
|
Missing a Javadoc comment. | 54 |
| Violation | Message | Line |
|---|---|---|
|
Class Data Abstraction Coupling is 14 (max allowed is 10) classes [BasicStroke, Date, DateAxis, DateTickUnit, Day, DaylightChartBand, DaylightChartLegendItemSource, IntervalMarker, LegendTitle, Options, RectangleInsets, StandardXYItemRenderer, TextTitle, XYPlot]. | 68 |
|
Class Fan-Out Complexity is 25 (max allowed is 20). | 68 |
|
'18' is a magic number. | 122 |
|
'5.0' is a magic number. | 197 |
|
'5.0' is a magic number. | 197 |
|
'5.0' is a magic number. | 197 |
|
'5.0' is a magic number. | 197 |
|
'18' is a magic number. | 226 |
|
'12' is a magic number. | 229 |
|
'12' is a magic number. | 260 |
|
'70' is a magic number. | 262 |
|
'70' is a magic number. | 262 |
|
'12' is a magic number. | 289 |
|
'1900' is a magic number. | 294 |
|
'11' is a magic number. | 295 |
|
'31' is a magic number. | 295 |
| Violation | Message | Line |
|---|---|---|
|
'0.1f' is a magic number. | 79 |
|
'0.8f' is a magic number. | 89 |
| Violation | Message | Line |
|---|---|---|
|
Class Messages should be declared as final. | 33 |
| Violation | Message | Line |
|---|---|---|
|
Missing a Javadoc comment. | 6 |
| Violation | Message | Line |
|---|---|---|
|
Class Fan-Out Complexity is 23 (max allowed is 20). | 67 |
|
Variable 'e' should be declared final. | 140 |
|
Method length is 63 lines (max allowed is 50). | 156 |
| Violation | Message | Line |
|---|---|---|
|
Class Data Abstraction Coupling is 26 (max allowed is 10) classes [AboutAction, ChartOptionsAction, ChartPanel, CloseCurrentTabAction, DaylightChartReport, ExitAction, File, ImageIcon, ItemListener, JCheckBoxMenuItem, JMenu, JMenuBar, JSplitPane, JToolBar, LocationsList, LocationsTabbedPane, OnlineHelpAction, OpenLocationTabAction, OpenLocationsFileAction, OpenReportFileAction, OptionsAction, PrintChartAction, ResetAllAction, SaveChartAction, SaveLocationsFileAction, SaveReportFileAction]. | 73 |
|
Class Fan-Out Complexity is 34 (max allowed is 20). | 73 |
|
'static' modifier out of order with the JLS suggestions. | 78 |
|
Executable statement count is 33 (max allowed is 30). | 107 |
|
Parameter location should be final. | 186 |
|
Variable 'location' should be declared final. | 186 |
|
Javadoc has empty description section. | 263 |
|
Parameter location should be final. | 276 |
|
Variable 'location' should be declared final. | 276 |
|
Parameter selectedLocation should be final. | 287 |
|
Variable 'selectedLocation' should be declared final. | 287 |
|
Parameter editedLocation should be final. | 287 |
|
Variable 'editedLocation' should be declared final. | 287 |
|
Executable statement count is 31 (max allowed is 30). | 335 |
|
'slimUi' hides a field. | 426 |
| Violation | Message | Line |
|---|---|---|
|
Class LocationDialog should be declared as final. | 73 |
|
Class Data Abstraction Coupling is 13 (max allowed is 10) classes [AbstractAction, Color, DefaultFormBuilder, DialogButtonListener, FocusListener, FormLayout, JButton, JComboBox, JTextField, Location, PointLocation, TimeZoneDisplay, Vector]. | 73 |
|
Class Fan-Out Complexity is 25 (max allowed is 20). | 73 |
|
Executable statement count is 46 (max allowed is 30). | 177 |
|
NCSS for this method is 62 (max allowed is 50). | 177 |
|
Anonymous inner class length is 33 lines (max allowed is 10). | 203 |
|
Parameter e should be final. | 205 |
|
Variable 'e' should be declared final. | 205 |
|
Parameter event should be final. | 209 |
|
Variable 'event' should be declared final. | 209 |
|
'10' is a magic number. | 245 |
|
'10' is a magic number. | 245 |
|
'10' is a magic number. | 245 |
|
'10' is a magic number. | 245 |
|
'3' is a magic number. | 256 |
|
Parameter actionEvent should be final. | 301 |
|
Variable 'actionEvent' should be declared final. | 301 |
|
'255' is a magic number. | 432 |
|
'255' is a magic number. | 432 |
|
'204' is a magic number. | 432 |
| Violation | Message | Line |
|---|---|---|
|
'20' is a magic number. | 88 |
|
Anonymous inner class length is 19 lines (max allowed is 10). | 90 |
|
Anonymous inner class length is 16 lines (max allowed is 10). | 110 |
|
Anonymous inner class length is 18 lines (max allowed is 10). | 127 |
|
'locations' hides a field. | 147 |
| Violation | Message | Line |
|---|---|---|
|
Class Messages should be declared as final. | 33 |
| Violation | Message | Line |
|---|---|---|
|
Class OptionsDialog should be declared as final. | 60 |
|
'10' is a magic number. | 175 |
|
'10' is a magic number. | 175 |
|
'10' is a magic number. | 175 |
|
'10' is a magic number. | 175 |
|
'3' is a magic number. | 189 |
|
Parameter actionEvent should be final. | 219 |
|
Variable 'actionEvent' should be declared final. | 219 |
| Violation | Message | Line |
|---|---|---|
|
Missing a Javadoc comment. | 6 |
| Violation | Message | Line |
|---|---|---|
|
Method length is 106 lines (max allowed is 50). | 97 |
|
NCSS for this method is 64 (max allowed is 50). | 97 |
|
Anonymous inner class length is 108 lines (max allowed is 10). | 101 |
|
Cyclomatic Complexity is 12 (max allowed is 10). | 103 |
| Violation | Message | Line |
|---|---|---|
|
Method length is 52 lines (max allowed is 50). | 72 |
|
Catching 'RuntimeException' is not allowed. | 120 |
| Violation | Message | Line |
|---|---|---|
|
Catching 'RuntimeException' is not allowed. | 104 |
| Violation | Message | Line |
|---|---|---|
|
Missing a Javadoc comment. | 6 |
| Violation | Message | Line |
|---|---|---|
|
Catching 'Exception' is not allowed. | 100 |
| Violation | Message | Line |
|---|---|---|
|
Catching 'Exception' is not allowed. | 90 |
| Violation | Message | Line |
|---|---|---|
|
Catching 'Exception' is not allowed. | 89 |
| Violation | Message | Line |
|---|---|---|
|
Class Actions should be declared as final. | 42 |
| Violation | Message | Line |
|---|---|---|
|
Utility classes should not have a public or default constructor. | 30 |
|
Name 'errMsg' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 33 |
|
Method length is 53 lines (max allowed is 50). | 43 |
|
Catching 'Exception' is not allowed. | 92 |
| Violation | Message | Line |
|---|---|---|
|
Anonymous inner class length is 17 lines (max allowed is 10). | 104 |
| Violation | Message | Line |
|---|---|---|
|
First sentence should end with a period. | 42 |
| Violation | Message | Line |
|---|---|---|
|
Catching 'Exception' is not allowed. | 93 |
|
First sentence should end with a period. | 100 |
| Violation | Message | Line |
|---|---|---|
|
Parameter data should be final. | 128 |
|
'data' hides a field. | 128 |
|
Variable 'data' should be declared final. | 128 |
| Violation | Message | Line |
|---|---|---|
|
Parameter settingsDirectory should be final. | 85 |
|
Variable 'settingsDirectory' should be declared final. | 85 |
|
Parameter resource should be final. | 86 |
|
Variable 'resource' should be declared final. | 86 |
|
Parameter fileType should be final. | 87 |
|
Variable 'fileType' should be declared final. | 87 |
|
switch without "default" clause. | 108 |
|
Catching 'Exception' is not allowed. | 127 |
|
Cyclomatic Complexity is 12 (max allowed is 10). | 136 |
|
Method length is 54 lines (max allowed is 50). | 136 |
|
switch without "default" clause. | 144 |
|
Catching 'Exception' is not allowed. | 164 |
|
Catching 'Exception' is not allowed. | 217 |
| Violation | Message | Line |
|---|---|---|
|
Javadoc has empty description section. | 146 |
| Violation | Message | Line |
|---|---|---|
|
Javadoc has empty description section. | 90 |
|
Javadoc has empty description section. | 98 |
|
Javadoc has empty description section. | 143 |
|
Javadoc has empty description section. | 151 |
|
Javadoc has empty description section. | 177 |
|
Javadoc has empty description section. | 205 |
|
Missing a Javadoc comment. | 231 |
| Violation | Message | Line |
|---|---|---|
|
Catching 'Exception' is not allowed. | 104 |
|
Catching 'Exception' is not allowed. | 162 |
| Violation | Message | Line |
|---|---|---|
|
Parameter fileType should be final. | 84 |
|
Variable 'fileType' should be declared final. | 84 |
|
Catching 'Exception' is not allowed. | 127 |
|
Catching 'Exception' is not allowed. | 181 |
| Violation | Message | Line |
|---|---|---|
|
Name 'scratchDirectory' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 39 |
|
Missing a Javadoc comment. | 77 |
|
Missing a Javadoc comment. | 111 |
|
Uncommented main method found. | 124 |
|
Missing a Javadoc comment. | 130 |
|
Missing a Javadoc comment. | 135 |
|
Missing a Javadoc comment. | 140 |
| Violation | Message | Line |
|---|---|---|
|
Import from illegal package - sun.reflect.generics.reflectiveObjects.NotImplementedException. | 32 |
|
Javadoc has empty description section. | 68 |
|
Javadoc has empty description section. | 76 |
|
Javadoc has empty description section. | 84 |
|
Javadoc has empty description section. | 92 |
|
Javadoc has empty description section. | 100 |
|
Javadoc has empty description section. | 108 |
|
Javadoc has empty description section. | 116 |
|
Javadoc has empty description section. | 124 |
|
Javadoc has empty description section. | 132 |
|
Javadoc has empty description section. | 140 |
|
Javadoc has empty description section. | 149 |
|
Javadoc has empty description section. | 158 |
|
Javadoc has empty description section. | 167 |
|
Javadoc has empty description section. | 176 |
|
Javadoc has empty description section. | 185 |
|
Javadoc has empty description section. | 194 |
|
Javadoc has empty description section. | 203 |
|
Javadoc has empty description section. | 212 |
| Violation | Message | Line |
|---|---|---|
|
Name 'chart' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 46 |
|
'chart' hides a field. | 50 |
|
'chart' hides a field. | 64 |
|
'chart' hides a field. | 107 |
| Violation | Message | Line |
|---|---|---|
|
Javadoc has empty description section. | 70 |
|
Javadoc has empty description section. | 78 |
|
Javadoc has empty description section. | 86 |
|
Javadoc has empty description section. | 94 |
|
Javadoc has empty description section. | 102 |
|
Javadoc has empty description section. | 111 |
| Violation | Message | Line |
|---|---|---|
|
Javadoc has empty description section. | 112 |
|
Javadoc has empty description section. | 120 |
|
Javadoc has empty description section. | 128 |
|
Javadoc has empty description section. | 136 |
|
Javadoc has empty description section. | 144 |
|
Javadoc has empty description section. | 152 |
|
Javadoc has empty description section. | 160 |
|
Javadoc has empty description section. | 169 |
|
Javadoc has empty description section. | 178 |
|
Javadoc has empty description section. | 187 |
| Violation | Message | Line |
|---|---|---|
|
Javadoc has empty description section. | 74 |
|
Javadoc has empty description section. | 82 |
|
Javadoc has empty description section. | 90 |
|
Expected @param tag for 'showTitle'. | 103 |
|
Javadoc has empty description section. | 108 |
|
Javadoc has empty description section. | 117 |
|
Javadoc has empty description section. | 126 |
| Violation | Message | Line |
|---|---|---|
|
Class Data Abstraction Coupling is 11 (max allowed is 10) classes [ArrayList, DecimalFormat, Equinox, File, FileWriter, LocalDate, LocalDateTime, PrintWriter, SunChartYearData, SunPosition, SunPositions]. | 52 |
|
Name 'sunAlgorithm' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 58 |
|
'24' is a magic number. | 80 |
|
Uncommented main method found. | 103 |
|
'12' is a magic number. | 147 |
|
'3' is a magic number. | 152 |
|
'6' is a magic number. | 155 |
|
'9' is a magic number. | 158 |
|
'12' is a magic number. | 161 |
|
'15' is a magic number. | 165 |
|
Parameter equinox3 should be final. | 173 |
|
Variable 'equinox3' should be declared final. | 173 |
|
'3' is a magic number. | 190 |
| Violation | Message | Line |
|---|---|---|
|
Javadoc has empty description section. | 64 |
| Violation | Message | Line |
|---|---|---|
|
Expected @param tag for 'dateTime'. | 36 |
|
Expected @param tag for 'solarEphemerides'. | 37 |
|
Javadoc has empty description section. | 64 |
|
Javadoc has empty description section. | 72 |
|
Javadoc has empty description section. | 80 |
|
Javadoc has empty description section. | 88 |
|
Javadoc has empty description section. | 136 |
| Violation | Message | Line |
|---|---|---|
|
Javadoc has empty description section. | 64 |
| Violation | Message | Line |
|---|---|---|
|
'18' is a magic number. | 103 |
|
'12' is a magic number. | 120 |
|
'12' is a magic number. | 129 |
|
'5.0' is a magic number. | 173 |
|
'5.0' is a magic number. | 173 |
|
'5.0' is a magic number. | 173 |
|
'5.0' is a magic number. | 173 |
