The following document contains the results of FindBugs Report
FindBugs Version is 1.2.1
Threshold is Low
Effort is Default
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 804 | 20 | 0 | 0 |
| Bug | Category | Details | Line |
|---|---|---|---|
| daylightchart.LauncherMain.fail(String) invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 135 |
| Bug | Category | Details | Line |
|---|---|---|---|
| daylightchart.daylightchart.calculation.RawRiseSet defines compareTo(RawRiseSet) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 70 |
| Bug | Category | Details | Line |
|---|---|---|---|
| daylightchart.daylightchart.calculation.RiseSet defines compareTo(RiseSet) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 162 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Found static field of type java.text.DateFormat in daylightchart.daylightchart.chart.ChartConfiguration.monthsFormat | MT_CORRECTNESS | STCAL_STATIC_SIMPLE_DATA_FORMAT_INSTANCE | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class daylightchart.gui.LocationsList$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 91-107 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Should daylightchart.gui.actions.OpenLocationTabAction$GuiActionListener be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 44-65 |
| Bug | Category | Details | Line |
|---|---|---|---|
| daylightchart.gui.util.ExitAction$1.actionPerformed(ActionEvent) invokes System.exit(...), which shuts down the entire virtual machine | BAD_PRACTICE | DM_EXIT | 60 |
| The class daylightchart.gui.util.ExitAction$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 56-61 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Possible null pointer dereference of BaseDataFile.BaseDataFile.data in daylightchart.options.BaseLocationsDataFile.load(InputStream[]) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 187 |
| Possible null pointer dereference of reader in daylightchart.options.BaseLocationsDataFile.load(InputStream[]) on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 161 |
| daylightchart.options.BaseLocationsDataFile.load(InputStream[]) may fail to close stream on exception | BAD_PRACTICE | OS_OPEN_STREAM_EXCEPTION_PATH | 147 |
| daylightchart.options.BaseLocationsDataFile.load(InputStream[]) may fail to close stream on exception | BAD_PRACTICE | OS_OPEN_STREAM_EXCEPTION_PATH | 152 |
| daylightchart.options.BaseLocationsDataFile.load(InputStream[]) may fail to close stream on exception | BAD_PRACTICE | OS_OPEN_STREAM_EXCEPTION_PATH | 157 |
| Exception is caught when Exception is not thrown in daylightchart.options.BaseLocationsDataFile.load() | STYLE | REC_CATCH_EXCEPTION | 127 |
| Exception is caught when Exception is not thrown in daylightchart.options.BaseLocationsDataFile.load(InputStream[]) | STYLE | REC_CATCH_EXCEPTION | 164 |
| Bug | Category | Details | Line |
|---|---|---|---|
| daylightchart.options.OptionsDataFile.load() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 79 |
| Bug | Category | Details | Line |
|---|---|---|---|
| daylightchart.options.ReportDataFile.load() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 104 |
| Redundant nullcheck of input, which is known to be non-null in daylightchart.options.ReportDataFile.load(InputStream[]) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 134 |
| Bug | Category | Details | Line |
|---|---|---|---|
| CommandLineParser.remainingArgs not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Use of non-localized String.toUpperCase() or String.toLowerCase | I18N | DM_CONVERT_CASE | 83 |
